From 0c881e374bb820e7fb79fc35ef4c77f4e10e9258 Mon Sep 17 00:00:00 2001
From: Ellpeck <me@ellpeck.de>
Date: Fri, 3 Dec 2021 12:52:26 +0100
Subject: [PATCH] Marked features related to Lidgren.Network as obsolete

---
 CHANGELOG.md                     | 3 +++
 MLEM.Data/MLEM.Data.csproj       | 1 +
 MLEM.Data/NetBufferSerializer.cs | 1 +
 MLEM.Data/NetExtensions.cs       | 8 ++++++++
 4 files changed, 13 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index bcc5b2c..5679acc 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -67,6 +67,9 @@ Improvements
 - **Use TitleContainer for opening streams where possible**
 - Set GraphicsResource Name when loading assets using RawContentManager
 
+Removals
+- Marked features related to Lidgren.Network as obsolete
+
 ## 5.1.0
 ### MLEM
 Additions
diff --git a/MLEM.Data/MLEM.Data.csproj b/MLEM.Data/MLEM.Data.csproj
index 87438d6..22eeca6 100644
--- a/MLEM.Data/MLEM.Data.csproj
+++ b/MLEM.Data/MLEM.Data.csproj
@@ -22,6 +22,7 @@
         <PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
         <ProjectReference Include="..\MLEM\MLEM.csproj" />
 
+        <!--TODO remove lidgren support eventually (methods marked as obsolete since 5.2.0)-->
         <PackageReference Include="Lidgren.Network" Version="1.0.2">
             <PrivateAssets>all</PrivateAssets>
         </PackageReference>
diff --git a/MLEM.Data/NetBufferSerializer.cs b/MLEM.Data/NetBufferSerializer.cs
index 05f23cf..db49f88 100644
--- a/MLEM.Data/NetBufferSerializer.cs
+++ b/MLEM.Data/NetBufferSerializer.cs
@@ -10,6 +10,7 @@ namespace MLEM.Data {
     /// It can be used both for serialization of outgoing packets, and deserialization of incoming packets.
     /// Before serializing and deserializing an object, each of the object's fields has to have a handler. New handlers can be added using <see cref="AddHandler{T}(System.Action{Lidgren.Network.NetBuffer,T},System.Func{Lidgren.Network.NetBuffer,T})"/> or <see cref="AddHandler{T}(Newtonsoft.Json.JsonSerializer)"/>.
     /// </summary>
+    [Obsolete("Lidgren.Network support is deprecated. Consider using LiteNetLib or a custom implementation instead.")]
     public class NetBufferSerializer {
 
         private readonly Dictionary<Type, Action<NetBuffer, object>> writeFunctions = new Dictionary<Type, Action<NetBuffer, object>>();
diff --git a/MLEM.Data/NetExtensions.cs b/MLEM.Data/NetExtensions.cs
index 7149b90..e6adf14 100644
--- a/MLEM.Data/NetExtensions.cs
+++ b/MLEM.Data/NetExtensions.cs
@@ -19,6 +19,7 @@ namespace MLEM.Data {
         /// </summary>
         /// <param name="buffer">The buffer to write to</param>
         /// <param name="vector">The vector to write</param>
+        [Obsolete("Lidgren.Network support is deprecated. Consider using LiteNetLib or a custom implementation instead.")]
         public static void Write(this NetBuffer buffer, Vector2 vector) {
             buffer.Write(vector.X);
             buffer.Write(vector.Y);
@@ -29,6 +30,7 @@ namespace MLEM.Data {
         /// </summary>
         /// <param name="buffer">The buffer to read from</param>
         /// <returns>The read vector</returns>
+        [Obsolete("Lidgren.Network support is deprecated. Consider using LiteNetLib or a custom implementation instead.")]
         public static Vector2 ReadVector2(this NetBuffer buffer) {
             return new Vector2(buffer.ReadFloat(), buffer.ReadFloat());
         }
@@ -38,6 +40,7 @@ namespace MLEM.Data {
         /// </summary>
         /// <param name="buffer">The buffer to write to</param>
         /// <param name="guid">The guid to write</param>
+        [Obsolete("Lidgren.Network support is deprecated. Consider using LiteNetLib or a custom implementation instead.")]
         public static void Write(this NetBuffer buffer, Guid guid) {
             buffer.Write(guid.ToByteArray());
         }
@@ -47,6 +50,7 @@ namespace MLEM.Data {
         /// </summary>
         /// <param name="buffer">The buffer to read from</param>
         /// <returns>The read guid</returns>
+        [Obsolete("Lidgren.Network support is deprecated. Consider using LiteNetLib or a custom implementation instead.")]
         public static Guid ReadGuid(this NetBuffer buffer) {
             return new Guid(buffer.ReadBytes(16));
         }
@@ -56,6 +60,7 @@ namespace MLEM.Data {
         /// </summary>
         /// <param name="buffer">The buffer to write to</param>
         /// <param name="direction">The direction to write</param>
+        [Obsolete("Lidgren.Network support is deprecated. Consider using LiteNetLib or a custom implementation instead.")]
         public static void Write(this NetBuffer buffer, Direction2 direction) {
             buffer.Write((short) direction);
         }
@@ -65,6 +70,7 @@ namespace MLEM.Data {
         /// </summary>
         /// <param name="buffer">The buffer to read from</param>
         /// <returns>The read direction</returns>
+        [Obsolete("Lidgren.Network support is deprecated. Consider using LiteNetLib or a custom implementation instead.")]
         public static Direction2 ReadDirection(this NetBuffer buffer) {
             return (Direction2) buffer.ReadInt16();
         }
@@ -76,6 +82,7 @@ namespace MLEM.Data {
         /// <param name="obj">The object to write</param>
         /// <param name="serializer">The JSON serializer to use</param>
         /// <typeparam name="T">The type of object written</typeparam>
+        [Obsolete("Lidgren.Network support is deprecated. Consider using LiteNetLib or a custom implementation instead.")]
         public static void WriteObject<T>(this NetBuffer buffer, T obj, JsonSerializer serializer) {
             if (EqualityComparer<T>.Default.Equals(obj, default)) {
                 buffer.Write(0);
@@ -97,6 +104,7 @@ namespace MLEM.Data {
         /// <param name="serializer">The JSON serializer to use</param>
         /// <typeparam name="T">The type of object read</typeparam>
         /// <returns>The read object</returns>
+        [Obsolete("Lidgren.Network support is deprecated. Consider using LiteNetLib or a custom implementation instead.")]
         public static T ReadObject<T>(this NetBuffer buffer, JsonSerializer serializer) {
             var length = buffer.ReadInt32();
             if (length <= 0)