build.gradle

@@ -13,7 +13,7 @@ apply plugin: 'net.minecraftforge.gradle'
 apply plugin: 'eclipse'
 apply plugin: 'maven-publish'
 
-version = '38.1'
+version = '38.0'
 group = 'de.ellpeck.naturesaura' // http://maven.apache.org/guides/mini/guide-naming-conventions.html
 archivesBaseName = 'NaturesAura'
 

src/generated/resources/data/forge/tags/items/tools/axes.json

@@ -1,7 +0,0 @@
-{
-  "values": [
-    "naturesaura:depth_axe",
-    "naturesaura:infused_iron_axe",
-    "naturesaura:sky_axe"
-  ]
-}

src/generated/resources/data/forge/tags/items/tools/hoes.json

@@ -1,7 +0,0 @@
-{
-  "values": [
-    "naturesaura:depth_hoe",
-    "naturesaura:infused_iron_hoe",
-    "naturesaura:sky_hoe"
-  ]
-}

src/generated/resources/data/forge/tags/items/tools/pickaxes.json

@@ -1,7 +0,0 @@
-{
-  "values": [
-    "naturesaura:depth_pickaxe",
-    "naturesaura:infused_iron_pickaxe",
-    "naturesaura:sky_pickaxe"
-  ]
-}

src/generated/resources/data/forge/tags/items/tools/shovels.json

@@ -1,7 +0,0 @@
-{
-  "values": [
-    "naturesaura:depth_shovel",
-    "naturesaura:infused_iron_shovel",
-    "naturesaura:sky_shovel"
-  ]
-}

src/generated/resources/data/forge/tags/items/tools/swords.json

@@ -1,7 +0,0 @@
-{
-  "values": [
-    "naturesaura:depth_sword",
-    "naturesaura:infused_iron_sword",
-    "naturesaura:sky_sword"
-  ]
-}

src/generated/resources/data/minecraft/tags/items/cluster_max_harvestables.json

@@ -1,7 +1,7 @@
 {
   "values": [
-    "naturesaura:depth_pickaxe",
     "naturesaura:infused_iron_pickaxe",
-    "naturesaura:sky_pickaxe"
+    "naturesaura:sky_pickaxe",
+    "naturesaura:depth_pickaxe"
   ]
 }

src/main/java/de/ellpeck/naturesaura/ModConfig.java

@@ -26,7 +26,6 @@ public final class ModConfig {
     public ConfigValue<Integer> fieldCreatorRange;
     public ConfigValue<Double> auraToRFRatio;
     public ConfigValue<Integer> maxAnimalsAroundPowder;
-    public ConfigValue<Integer> maxAuraSpreadRange;
 
     public ConfigValue<Boolean> rfConverter;
     public ConfigValue<Boolean> chunkLoader;
@@ -89,10 +88,6 @@ public final class ModConfig {
                 .comment("The maximum amount of animals that can be around the powder of fertility before it stops working")
                 .translation("config." + NaturesAura.MOD_ID + ".maxAnimalsAroundPowder")
                 .define("maxAnimalsAroundPowder", 200);
-        this.maxAuraSpreadRange = builder
-                .comment("The maximum amount of blocks that aura can spread from an initial position before it starts fizzling out. It's recommended to lower this value on a large server to avoid lag caused by players chunk-loading their bases for extended amounts of time without an Aura Detector present.")
-                .translation("config." + NaturesAura.MOD_ID + ".maxAuraSpreadRange")
-                .define("maxAuraSpreadRange", 150);
         builder.pop();
 
         builder.push("features");

src/main/java/de/ellpeck/naturesaura/api/aura/chunk/IAuraChunk.java

@@ -2,7 +2,6 @@ package de.ellpeck.naturesaura.api.aura.chunk;
 
 import de.ellpeck.naturesaura.api.NaturesAuraAPI;
 import de.ellpeck.naturesaura.api.aura.type.IAuraType;
-import de.ellpeck.naturesaura.chunk.AuraChunk;
 import net.minecraft.core.BlockPos;
 import net.minecraft.nbt.CompoundTag;
 import net.minecraft.world.level.Level;
@@ -152,8 +151,6 @@ public interface IAuraChunk extends INBTSerializable<CompoundTag> {
      */
     int storeAura(BlockPos pos, int amount);
 
-    AuraChunk.DrainSpot getActualDrainSpot(BlockPos pos, boolean make);
-
     int getDrainSpot(BlockPos pos);
 
     IAuraType getType();

src/main/java/de/ellpeck/naturesaura/api/aura/chunk/IDrainSpotEffect.java

@@ -1,7 +1,6 @@
 package de.ellpeck.naturesaura.api.aura.chunk;
 
 import de.ellpeck.naturesaura.api.aura.type.IAuraType;
-import de.ellpeck.naturesaura.chunk.AuraChunk;
 import net.minecraft.core.BlockPos;
 import net.minecraft.resources.ResourceLocation;
 import net.minecraft.world.entity.player.Player;
@@ -11,7 +10,7 @@ import net.minecraft.world.level.chunk.LevelChunk;
 
 public interface IDrainSpotEffect {
 
-    void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot, AuraChunk.DrainSpot actualSpot);
+    void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot);
 
     boolean appliesHere(LevelChunk chunk, IAuraChunk auraChunk, IAuraType type);
 

src/main/java/de/ellpeck/naturesaura/chunk/AuraChunk.java

@@ -2,7 +2,6 @@ package de.ellpeck.naturesaura.chunk;
 
 import com.google.common.collect.HashBasedTable;
 import com.google.common.collect.Table;
-import de.ellpeck.naturesaura.ModConfig;
 import de.ellpeck.naturesaura.api.NaturesAuraAPI;
 import de.ellpeck.naturesaura.api.aura.chunk.IAuraChunk;
 import de.ellpeck.naturesaura.api.aura.chunk.IDrainSpotEffect;
@@ -25,7 +24,6 @@ import org.apache.commons.lang3.mutable.MutableObject;
 import org.apache.commons.lang3.tuple.Pair;
 
 import java.util.ArrayList;
-import java.util.Collection;
 import java.util.List;
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
@@ -35,7 +33,7 @@ public class AuraChunk implements IAuraChunk {
 
     private final LevelChunk chunk;
     private final IAuraType type;
-    private final Map<BlockPos, DrainSpot> drainSpots = new ConcurrentHashMap<>();
+    private final Map<BlockPos, MutableInt> drainSpots = new ConcurrentHashMap<>();
     private final Table<BlockPos, Integer, Pair<Integer, Integer>> auraAndSpotAmountCache = HashBasedTable.create();
     private final Table<BlockPos, Integer, Pair<BlockPos, Integer>[]> limitSpotCache = HashBasedTable.create();
     private final List<IDrainSpotEffect> effects = new ArrayList<>();
@@ -105,12 +103,11 @@ public class AuraChunk implements IAuraChunk {
         return this.storeAura(pos, amount, true, false);
     }
 
-    @Override
+    private MutableInt getActualDrainSpot(BlockPos pos, boolean make) {
-    public DrainSpot getActualDrainSpot(BlockPos pos, boolean make) {
         var spot = this.drainSpots.get(pos);
         if (spot == null && make) {
-            spot = new DrainSpot(pos, 0);
+            spot = new MutableInt();
-            this.addDrainSpot(spot);
+            this.addDrainSpot(pos, spot);
         }
         return spot;
     }
@@ -121,20 +118,20 @@ public class AuraChunk implements IAuraChunk {
         return spot == null ? 0 : spot.intValue();
     }
 
-    private void addDrainSpot(DrainSpot spot) {
+    private void addDrainSpot(BlockPos pos, MutableInt spot) {
-        var expX = spot.pos.getX() >> 4;
+        var expX = pos.getX() >> 4;
-        var expZ = spot.pos.getZ() >> 4;
+        var expZ = pos.getZ() >> 4;
         var myPos = this.chunk.getPos();
         if (expX != myPos.x || expZ != myPos.z)
-            throw new IllegalArgumentException("Tried to add drain spot " + spot.pos + " to chunk at " + myPos.x + ", " + myPos.z + " when it should've been added to chunk at " + expX + ", " + expZ);
+            throw new IllegalArgumentException("Tried to add drain spot " + pos + " to chunk at " + myPos.x + ", " + myPos.z + " when it should've been added to chunk at " + expX + ", " + expZ);
 
-        this.drainSpots.put(spot.pos, spot);
+        this.drainSpots.put(pos, spot);
     }
 
-    public void setSpots(Collection<DrainSpot> spots) {
+    public void setSpots(Map<BlockPos, MutableInt> spots) {
         this.drainSpots.clear();
-        for (var spot : spots)
+        for (var entry : spots.entrySet())
-            this.addDrainSpot(spot);
+            this.addDrainSpot(entry.getKey(), entry.getValue());
         this.addOrRemoveAsActive();
     }
 
@@ -155,13 +152,11 @@ public class AuraChunk implements IAuraChunk {
     public void update() {
         var level = this.chunk.getLevel();
 
-        for (var spot : this.drainSpots.values()) {
+        for (var entry : this.drainSpots.entrySet()) {
+            var pos = entry.getKey();
+            var amount = entry.getValue();
             for (var effect : this.effects)
-                effect.update(level, this.chunk, this, spot.pos, spot.intValue(), spot);
+                effect.update(level, this.chunk, this, pos, amount.intValue());
-
-            // cause this spot to fizzle out if it's over the range limit
-            if (spot.intValue() > 0 && spot.originalSpreadPos != null && !spot.originalSpreadPos.closerThan(spot.pos, ModConfig.instance.maxAuraSpreadRange.get()))
-                this.drainAura(spot.pos, spot.intValue());
         }
 
         if (this.needsSync) {
@@ -175,7 +170,7 @@ public class AuraChunk implements IAuraChunk {
 
     public PacketAuraChunk makePacket() {
         var pos = this.chunk.getPos();
-        return new PacketAuraChunk(pos.x, pos.z, this.drainSpots.values());
+        return new PacketAuraChunk(pos.x, pos.z, this.drainSpots);
     }
 
     public void getSpots(BlockPos pos, int radius, BiConsumer<BlockPos, Integer> consumer) {
@@ -250,8 +245,13 @@ public class AuraChunk implements IAuraChunk {
     @Override
     public CompoundTag serializeNBT() {
         var list = new ListTag();
-        for (var spot : this.drainSpots.values())
+        for (var entry : this.drainSpots.entrySet()) {
-            list.add(spot.serializeNBT());
+            var tag = new CompoundTag();
+            tag.putLong("pos", entry.getKey().asLong());
+            tag.putInt("amount", entry.getValue().intValue());
+            list.add(tag);
+        }
+
         var compound = new CompoundTag();
         compound.put("drain_spots", list);
         return compound;
@@ -261,8 +261,12 @@ public class AuraChunk implements IAuraChunk {
     public void deserializeNBT(CompoundTag compound) {
         this.drainSpots.clear();
         var list = compound.getList("drain_spots", 10);
-        for (var base : list)
+        for (var base : list) {
-            this.addDrainSpot(new DrainSpot((CompoundTag) base));
+            var tag = (CompoundTag) base;
+            this.addDrainSpot(
+                    BlockPos.of(tag.getLong("pos")),
+                    new MutableInt(tag.getInt("amount")));
+        }
         this.addOrRemoveAsActive();
     }
 
@@ -275,30 +279,4 @@ public class AuraChunk implements IAuraChunk {
             data.auraChunksWithSpots.remove(chunkPos);
         }
     }
-
-    public static class DrainSpot extends MutableInt {
-
-        public final BlockPos pos;
-        public BlockPos originalSpreadPos;
-
-        public DrainSpot(BlockPos pos, int value) {
-            super(value);
-            this.pos = pos;
-        }
-
-        public DrainSpot(CompoundTag tag) {
-            this(BlockPos.of(tag.getLong("pos")), tag.getInt("amount"));
-            if (tag.contains("original_spread_pos"))
-                this.originalSpreadPos = BlockPos.of(tag.getLong("original_spread_pos"));
-        }
-
-        public CompoundTag serializeNBT() {
-            var ret = new CompoundTag();
-            ret.putLong("pos", this.pos.asLong());
-            ret.putInt("amount", this.intValue());
-            if (this.originalSpreadPos != null)
-                ret.putLong("original_spread_pos", this.originalSpreadPos.asLong());
-            return ret;
-        }
-    }
 }

src/main/java/de/ellpeck/naturesaura/chunk/effect/AngerEffect.java

@@ -5,7 +5,6 @@ import de.ellpeck.naturesaura.NaturesAura;
 import de.ellpeck.naturesaura.api.aura.chunk.IAuraChunk;
 import de.ellpeck.naturesaura.api.aura.chunk.IDrainSpotEffect;
 import de.ellpeck.naturesaura.api.aura.type.IAuraType;
-import de.ellpeck.naturesaura.chunk.AuraChunk;
 import net.minecraft.core.BlockPos;
 import net.minecraft.resources.ResourceLocation;
 import net.minecraft.world.entity.LivingEntity;
@@ -52,7 +51,7 @@ public class AngerEffect implements IDrainSpotEffect {
     }
 
     @Override
-    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot, AuraChunk.DrainSpot actualSpot) {
+    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot) {
         if (level.getGameTime() % 100 != 0)
             return;
         if (!this.calcValues(level, pos, spot))

src/main/java/de/ellpeck/naturesaura/chunk/effect/AnimalEffect.java

@@ -6,7 +6,6 @@ import de.ellpeck.naturesaura.api.NaturesAuraAPI;
 import de.ellpeck.naturesaura.api.aura.chunk.IAuraChunk;
 import de.ellpeck.naturesaura.api.aura.chunk.IDrainSpotEffect;
 import de.ellpeck.naturesaura.api.aura.type.IAuraType;
-import de.ellpeck.naturesaura.chunk.AuraChunk;
 import net.minecraft.core.BlockPos;
 import net.minecraft.core.particles.ParticleTypes;
 import net.minecraft.resources.ResourceLocation;
@@ -64,7 +63,7 @@ public class AnimalEffect implements IDrainSpotEffect {
     }
 
     @Override
-    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot, AuraChunk.DrainSpot actualSpot) {
+    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot) {
         if (level.getGameTime() % 200 != 0)
             return;
         if (!this.calcValues(level, pos, spot))

src/main/java/de/ellpeck/naturesaura/chunk/effect/BalanceEffect.java

@@ -4,7 +4,6 @@ import de.ellpeck.naturesaura.NaturesAura;
 import de.ellpeck.naturesaura.api.aura.chunk.IAuraChunk;
 import de.ellpeck.naturesaura.api.aura.chunk.IDrainSpotEffect;
 import de.ellpeck.naturesaura.api.aura.type.IAuraType;
-import de.ellpeck.naturesaura.chunk.AuraChunk;
 import net.minecraft.core.BlockPos;
 import net.minecraft.resources.ResourceLocation;
 import net.minecraft.world.level.Level;
@@ -16,7 +15,7 @@ public class BalanceEffect implements IDrainSpotEffect {
     public static final ResourceLocation NAME = new ResourceLocation(NaturesAura.MOD_ID, "balance");
 
     @Override
-    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot, AuraChunk.DrainSpot actualSpot) {
+    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot) {
         if (spot < 100000)
             return;
         if (level.getGameTime() % 200 != 0)

src/main/java/de/ellpeck/naturesaura/chunk/effect/BreathlessEffect.java

@@ -5,7 +5,6 @@ import de.ellpeck.naturesaura.NaturesAura;
 import de.ellpeck.naturesaura.api.aura.chunk.IAuraChunk;
 import de.ellpeck.naturesaura.api.aura.chunk.IDrainSpotEffect;
 import de.ellpeck.naturesaura.api.aura.type.IAuraType;
-import de.ellpeck.naturesaura.chunk.AuraChunk;
 import de.ellpeck.naturesaura.potion.ModPotions;
 import net.minecraft.core.BlockPos;
 import net.minecraft.resources.ResourceLocation;
@@ -55,7 +54,7 @@ public class BreathlessEffect implements IDrainSpotEffect {
     }
 
     @Override
-    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot, AuraChunk.DrainSpot actualSpot) {
+    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot) {
         if (level.getGameTime() % 100 != 0)
             return;
         if (!this.calcValues(level, pos, spot))

src/main/java/de/ellpeck/naturesaura/chunk/effect/CacheRechargeEffect.java

@@ -6,7 +6,6 @@ import de.ellpeck.naturesaura.api.NaturesAuraAPI;
 import de.ellpeck.naturesaura.api.aura.chunk.IAuraChunk;
 import de.ellpeck.naturesaura.api.aura.chunk.IDrainSpotEffect;
 import de.ellpeck.naturesaura.api.aura.type.IAuraType;
-import de.ellpeck.naturesaura.chunk.AuraChunk;
 import de.ellpeck.naturesaura.items.ModItems;
 import net.minecraft.core.BlockPos;
 import net.minecraft.resources.ResourceLocation;
@@ -54,7 +53,7 @@ public class CacheRechargeEffect implements IDrainSpotEffect {
     }
 
     @Override
-    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot, AuraChunk.DrainSpot actualSpot) {
+    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot) {
         if (!this.calcValues(level, pos, spot))
             return;
         var players = level.getEntitiesOfClass(Player.class, this.bb);

src/main/java/de/ellpeck/naturesaura/chunk/effect/ExplosionEffect.java

@@ -5,7 +5,6 @@ import de.ellpeck.naturesaura.NaturesAura;
 import de.ellpeck.naturesaura.api.aura.chunk.IAuraChunk;
 import de.ellpeck.naturesaura.api.aura.chunk.IDrainSpotEffect;
 import de.ellpeck.naturesaura.api.aura.type.IAuraType;
-import de.ellpeck.naturesaura.chunk.AuraChunk;
 import net.minecraft.core.BlockPos;
 import net.minecraft.resources.ResourceLocation;
 import net.minecraft.util.Mth;
@@ -55,7 +54,7 @@ public class ExplosionEffect implements IDrainSpotEffect {
     }
 
     @Override
-    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot, AuraChunk.DrainSpot actualSpot) {
+    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot) {
         if (level.getGameTime() % 40 != 0)
             return;
         if (!this.calcValues(level, pos, spot))

src/main/java/de/ellpeck/naturesaura/chunk/effect/GrassDieEffect.java

@@ -7,7 +7,6 @@ import de.ellpeck.naturesaura.api.aura.chunk.IAuraChunk;
 import de.ellpeck.naturesaura.api.aura.chunk.IDrainSpotEffect;
 import de.ellpeck.naturesaura.api.aura.type.IAuraType;
 import de.ellpeck.naturesaura.blocks.ModBlocks;
-import de.ellpeck.naturesaura.chunk.AuraChunk;
 import net.minecraft.core.BlockPos;
 import net.minecraft.resources.ResourceLocation;
 import net.minecraft.util.Mth;
@@ -58,7 +57,7 @@ public class GrassDieEffect implements IDrainSpotEffect {
     }
 
     @Override
-    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot, AuraChunk.DrainSpot actualSpot) {
+    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot) {
         if (!this.calcValues(level, pos, spot))
             return;
         for (var i = this.amount / 2 + level.random.nextInt(this.amount / 2); i >= 0; i--) {

src/main/java/de/ellpeck/naturesaura/chunk/effect/NetherDecayEffect.java

@@ -6,7 +6,6 @@ import de.ellpeck.naturesaura.api.NaturesAuraAPI;
 import de.ellpeck.naturesaura.api.aura.chunk.IAuraChunk;
 import de.ellpeck.naturesaura.api.aura.chunk.IDrainSpotEffect;
 import de.ellpeck.naturesaura.api.aura.type.IAuraType;
-import de.ellpeck.naturesaura.chunk.AuraChunk;
 import net.minecraft.core.BlockPos;
 import net.minecraft.core.Direction;
 import net.minecraft.resources.ResourceLocation;
@@ -57,7 +56,7 @@ public class NetherDecayEffect implements IDrainSpotEffect {
     }
 
     @Override
-    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot, AuraChunk.DrainSpot actualSpot) {
+    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot) {
         if (!this.calcValues(level, pos, spot))
             return;
         for (var i = this.amount / 2 + level.random.nextInt(this.amount / 2); i >= 0; i--) {

src/main/java/de/ellpeck/naturesaura/chunk/effect/NetherGrassEffect.java

@@ -7,7 +7,6 @@ import de.ellpeck.naturesaura.api.aura.chunk.IAuraChunk;
 import de.ellpeck.naturesaura.api.aura.chunk.IDrainSpotEffect;
 import de.ellpeck.naturesaura.api.aura.type.IAuraType;
 import de.ellpeck.naturesaura.blocks.ModBlocks;
-import de.ellpeck.naturesaura.chunk.AuraChunk;
 import de.ellpeck.naturesaura.packet.PacketHandler;
 import de.ellpeck.naturesaura.packet.PacketParticles;
 import net.minecraft.core.BlockPos;
@@ -58,7 +57,7 @@ public class NetherGrassEffect implements IDrainSpotEffect {
     }
 
     @Override
-    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot, AuraChunk.DrainSpot actualSpot) {
+    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot) {
         if (level.getGameTime() % 40 != 0)
             return;
         if (!this.calcValues(level, pos, spot))

src/main/java/de/ellpeck/naturesaura/chunk/effect/OreSpawnEffect.java

@@ -7,7 +7,6 @@ import de.ellpeck.naturesaura.api.aura.chunk.IAuraChunk;
 import de.ellpeck.naturesaura.api.aura.chunk.IDrainSpotEffect;
 import de.ellpeck.naturesaura.api.aura.type.IAuraType;
 import de.ellpeck.naturesaura.api.misc.WeightedOre;
-import de.ellpeck.naturesaura.chunk.AuraChunk;
 import net.minecraft.core.BlockPos;
 import net.minecraft.core.Direction;
 import net.minecraft.resources.ResourceLocation;
@@ -74,7 +73,7 @@ public class OreSpawnEffect implements IDrainSpotEffect {
     }
 
     @Override
-    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot, AuraChunk.DrainSpot actualSpot) {
+    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot) {
         if (level.getGameTime() % 40 != 0)
             return;
         if (!this.calcValues(level, pos, spot))

src/main/java/de/ellpeck/naturesaura/chunk/effect/PlantBoostEffect.java

@@ -7,7 +7,6 @@ import de.ellpeck.naturesaura.api.NaturesAuraAPI;
 import de.ellpeck.naturesaura.api.aura.chunk.IAuraChunk;
 import de.ellpeck.naturesaura.api.aura.chunk.IDrainSpotEffect;
 import de.ellpeck.naturesaura.api.aura.type.IAuraType;
-import de.ellpeck.naturesaura.chunk.AuraChunk;
 import de.ellpeck.naturesaura.packet.PacketHandler;
 import de.ellpeck.naturesaura.packet.PacketParticles;
 import net.minecraft.core.BlockPos;
@@ -64,7 +63,7 @@ public class PlantBoostEffect implements IDrainSpotEffect {
     }
 
     @Override
-    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot, AuraChunk.DrainSpot actualSpot) {
+    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot) {
         if (!this.calcValues(level, pos, spot))
             return;
         for (var i = this.amount / 2 + level.random.nextInt(this.amount / 2); i >= 0; i--) {

src/main/java/de/ellpeck/naturesaura/chunk/effect/ReplenishingEffect.java

@@ -7,7 +7,6 @@ import de.ellpeck.naturesaura.api.aura.chunk.IAuraChunk;
 import de.ellpeck.naturesaura.api.aura.chunk.IDrainSpotEffect;
 import de.ellpeck.naturesaura.api.aura.chunk.ISpotDrainable;
 import de.ellpeck.naturesaura.api.aura.type.IAuraType;
-import de.ellpeck.naturesaura.chunk.AuraChunk;
 import net.minecraft.core.BlockPos;
 import net.minecraft.resources.ResourceLocation;
 import net.minecraft.world.level.Level;
@@ -21,7 +20,7 @@ public class ReplenishingEffect implements IDrainSpotEffect {
     public static final ResourceLocation NAME = new ResourceLocation(NaturesAura.MOD_ID, "replenishing");
 
     @Override
-    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot, AuraChunk.DrainSpot actualSpot) {
+    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot) {
         if (spot < 0) {
             List<ISpotDrainable> tiles = new ArrayList<>();
             Helper.getBlockEntitiesInArea(level, pos, 25, tile -> {

src/main/java/de/ellpeck/naturesaura/chunk/effect/SpreadEffect.java

@@ -4,7 +4,6 @@ import de.ellpeck.naturesaura.NaturesAura;
 import de.ellpeck.naturesaura.api.aura.chunk.IAuraChunk;
 import de.ellpeck.naturesaura.api.aura.chunk.IDrainSpotEffect;
 import de.ellpeck.naturesaura.api.aura.type.IAuraType;
-import de.ellpeck.naturesaura.chunk.AuraChunk;
 import net.minecraft.core.BlockPos;
 import net.minecraft.core.Direction;
 import net.minecraft.resources.ResourceLocation;
@@ -17,7 +16,7 @@ public class SpreadEffect implements IDrainSpotEffect {
     public static final ResourceLocation NAME = new ResourceLocation(NaturesAura.MOD_ID, "spread");
 
     @Override
-    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot, AuraChunk.DrainSpot actualSpot) {
+    public void update(Level level, LevelChunk chunk, IAuraChunk auraChunk, BlockPos pos, Integer spot) {
         if (Math.abs(spot) < 500000 || Math.abs(IAuraChunk.getAuraInArea(level, pos, 25) - IAuraChunk.DEFAULT_AURA) < 1000000)
             return;
         var drain = spot > 0;
@@ -51,18 +50,7 @@ public class SpreadEffect implements IDrainSpotEffect {
                 moved = bestChunk.drainAura(bestPos, perSide);
                 auraChunk.storeAura(pos, moved);
             }
-            if (moved != 0) {
+            toMove -= moved;
-                var bestSpot = bestChunk.getActualDrainSpot(bestPos, false);
-                if (bestSpot != null && bestSpot.originalSpreadPos == null) {
-                    // propagate the spread position that we came from
-                    bestSpot.originalSpreadPos = actualSpot.originalSpreadPos;
-                    // if we didn't come from a spread position, our own position is the original
-                    if (bestSpot.originalSpreadPos == null)
-                        bestSpot.originalSpreadPos = pos;
-                    bestChunk.markDirty();
-                }
-                toMove -= moved;
-            }
         }
     }
 

src/main/java/de/ellpeck/naturesaura/data/ItemTagProvider.java

@@ -3,9 +3,6 @@ package de.ellpeck.naturesaura.data;
 import de.ellpeck.naturesaura.NaturesAura;
 import de.ellpeck.naturesaura.compat.Compat;
 import de.ellpeck.naturesaura.items.ModItems;
-import de.ellpeck.naturesaura.items.tools.*;
-import de.ellpeck.naturesaura.reg.IModItem;
-import de.ellpeck.naturesaura.reg.ModRegistry;
 import net.minecraft.data.DataGenerator;
 import net.minecraft.data.tags.BlockTagsProvider;
 import net.minecraft.data.tags.ItemTagsProvider;
@@ -16,8 +13,6 @@ import net.minecraft.world.item.Item;
 import net.minecraftforge.common.Tags;
 import net.minecraftforge.common.data.ExistingFileHelper;
 
-import java.util.Comparator;
-
 public class ItemTagProvider extends ItemTagsProvider {
 
     public ItemTagProvider(DataGenerator generatorIn, BlockTagsProvider blockTagProvider, ExistingFileHelper helper) {
@@ -34,22 +29,7 @@ public class ItemTagProvider extends ItemTagsProvider {
         this.copy(BlockTags.SLABS, ItemTags.SLABS);
 
         this.tag(Tags.Items.RODS_WOODEN).add(ModItems.ANCIENT_STICK);
-
+        this.tag(ItemTags.CLUSTER_MAX_HARVESTABLES).add(ModItems.INFUSED_IRON_PICKAXE, ModItems.SKY_PICKAXE, ModItems.DEPTH_PICKAXE);
-        // sort these so that they don't change the json every time we run data (because it's a set)
-        ModRegistry.ALL_ITEMS.stream().sorted(Comparator.comparing(IModItem::getBaseName)).filter(i -> i instanceof Item).map(i -> (Item) i).forEach(i -> {
-            if (i instanceof ItemPickaxe) {
-                this.tag(ItemTags.CLUSTER_MAX_HARVESTABLES).add(i);
-                this.tag(Tags.Items.TOOLS_PICKAXES).add(i);
-            } else if (i instanceof ItemAxe) {
-                this.tag(Tags.Items.TOOLS_AXES).add(i);
-            } else if (i instanceof ItemHoe) {
-                this.tag(Tags.Items.TOOLS_HOES).add(i);
-            } else if (i instanceof ItemSword) {
-                this.tag(Tags.Items.TOOLS_SWORDS).add(i);
-            } else if (i instanceof ItemShovel) {
-                this.tag(Tags.Items.TOOLS_SHOVELS).add(i);
-            }
-        });
 
         Compat.addItemTags(this);
     }

src/main/java/de/ellpeck/naturesaura/events/ClientEvents.java

@@ -424,12 +424,9 @@ public class ClientEvents {
 
                 if (ClientEvents.hoveringAuraSpot != null) {
                     var format = NumberFormat.getInstance();
-                    var spot = IAuraChunk.getAuraChunk(mc.level, ClientEvents.hoveringAuraSpot).getActualDrainSpot(ClientEvents.hoveringAuraSpot, false);
+                    var amount = IAuraChunk.getAuraChunk(mc.level, ClientEvents.hoveringAuraSpot).getDrainSpot(ClientEvents.hoveringAuraSpot);
-                    var color = spot.intValue() > 0 ? ChatFormatting.GREEN : ChatFormatting.RED;
+                    var color = amount > 0 ? ChatFormatting.GREEN : ChatFormatting.RED;
-                    mc.font.drawShadow(stack, "Pos: " + spot.pos.toShortString(), res.getGuiScaledWidth() / 2F + 5, res.getGuiScaledHeight() / 2F - 20, 0xFFFFFF);
+                    mc.font.drawShadow(stack, color + format.format(amount), res.getGuiScaledWidth() / 2F + 5, res.getGuiScaledHeight() / 2F - 11, 0xFFFFFF);
-                    mc.font.drawShadow(stack, "Amount: " + color + format.format(spot.intValue()), res.getGuiScaledWidth() / 2F + 5, res.getGuiScaledHeight() / 2F - 10, 0xFFFFFF);
-                    if (spot.originalSpreadPos != null)
-                        mc.font.drawShadow(stack, "Dist from Original: " + (int) Math.sqrt(spot.pos.distSqr(spot.originalSpreadPos)) + " (" + spot.originalSpreadPos.toShortString() + ")", res.getGuiScaledWidth() / 2F + 5, res.getGuiScaledHeight() / 2F, 0xFFFFFF);
                 }
             }
         }

src/main/java/de/ellpeck/naturesaura/items/tools/ItemArmor.java

@@ -25,14 +25,14 @@ import net.minecraftforge.registries.ForgeRegistries;
 
 import javax.annotation.Nullable;
 import java.util.Comparator;
+import java.util.HashMap;
 import java.util.Map;
 import java.util.UUID;
-import java.util.concurrent.ConcurrentHashMap;
 
 public class ItemArmor extends ArmorItem implements IModItem {
 
     private static final AttributeModifier SKY_MOVEMENT_MODIFIER = new AttributeModifier(UUID.fromString("c1f96acc-e117-4dc1-a351-e196a4de6071"), NaturesAura.MOD_ID + ":sky_movement_speed", 0.15F, AttributeModifier.Operation.MULTIPLY_TOTAL);
-    private static final Map<ArmorMaterial, Item[]> SETS = new ConcurrentHashMap<>();
+    private static final Map<ArmorMaterial, Item[]> SETS = new HashMap<>();
     private final String baseName;
 
     public ItemArmor(String baseName, ArmorMaterial materialIn, EquipmentSlot equipmentSlotIn) {

src/main/java/de/ellpeck/naturesaura/misc/ColoredBlockHelper.java

@@ -3,11 +3,11 @@ package de.ellpeck.naturesaura.misc;
 import net.minecraft.resources.ResourceLocation;
 import net.minecraft.world.item.DyeColor;
 import net.minecraft.world.level.block.Block;
-import net.minecraft.world.level.block.Blocks;
 import net.minecraftforge.registries.ForgeRegistries;
 
+import java.util.ArrayList;
 import java.util.Arrays;
-import java.util.Comparator;
+import java.util.Collections;
 import java.util.List;
 
 public final class ColoredBlockHelper {
@@ -17,18 +17,15 @@ public final class ColoredBlockHelper {
     public static final List<Block> CONCRETE_POWDER = ColoredBlockHelper.collectBlocks("concrete_powder");
     public static final List<Block> CONCRETE = ColoredBlockHelper.collectBlocks("concrete");
     public static final List<Block> GLASS = ColoredBlockHelper.collectBlocks("stained_glass");
-    public static final List<Block> GLASS_PANE = ColoredBlockHelper.collectBlocks("stained_glass_pane");
+    public static final List<Block> GLASS_PANE = ColoredBlockHelper.collectBlocks("glass_pane");
     public static final List<Block> CARPET = ColoredBlockHelper.collectBlocks("carpet");
     public static final List<List<Block>> LISTS = Arrays.asList(ColoredBlockHelper.WOOL, ColoredBlockHelper.TERRACOTTA, ColoredBlockHelper.CONCRETE_POWDER, ColoredBlockHelper.CONCRETE, ColoredBlockHelper.GLASS, ColoredBlockHelper.GLASS_PANE, ColoredBlockHelper.CARPET);
 
     private static List<Block> collectBlocks(String name) {
-        return Arrays.stream(DyeColor.values()).sorted(Comparator.comparingInt(DyeColor::getId)).map(c -> {
+        List<Block> blocks = new ArrayList<>();
-            var loc = new ResourceLocation(c.getName() + '_' + name);
+        for (var color : DyeColor.values())
-            var block = ForgeRegistries.BLOCKS.getValue(loc);
+            blocks.add(ForgeRegistries.BLOCKS.getValue(new ResourceLocation(color.getName() + '_' + name)));
-            if (block == null || block == Blocks.AIR)
+        return Collections.unmodifiableList(blocks);
-                throw new IllegalStateException("Couldn't find block with name " + loc);
-            return block;
-        }).toList();
     }
 
     public static List<Block> getBlocksContaining(Block block) {

src/main/java/de/ellpeck/naturesaura/packet/PacketAuraChunk.java

@@ -4,22 +4,23 @@ import de.ellpeck.naturesaura.NaturesAura;
 import de.ellpeck.naturesaura.api.NaturesAuraAPI;
 import de.ellpeck.naturesaura.chunk.AuraChunk;
 import de.ellpeck.naturesaura.events.ClientEvents;
+import net.minecraft.core.BlockPos;
 import net.minecraft.network.FriendlyByteBuf;
 import net.minecraft.world.level.Level;
 import net.minecraftforge.network.NetworkEvent;
+import org.apache.commons.lang3.mutable.MutableInt;
 
-import java.util.ArrayList;
+import java.util.HashMap;
-import java.util.Collection;
+import java.util.Map;
-import java.util.List;
 import java.util.function.Supplier;
 
 public class PacketAuraChunk {
 
     private int chunkX;
     private int chunkZ;
-    private Collection<AuraChunk.DrainSpot> drainSpots;
+    private Map<BlockPos, MutableInt> drainSpots;
 
-    public PacketAuraChunk(int chunkX, int chunkZ, Collection<AuraChunk.DrainSpot> drainSpots) {
+    public PacketAuraChunk(int chunkX, int chunkZ, Map<BlockPos, MutableInt> drainSpots) {
         this.chunkX = chunkX;
         this.chunkZ = chunkZ;
         this.drainSpots = drainSpots;
@@ -33,10 +34,14 @@ public class PacketAuraChunk {
         packet.chunkX = buf.readInt();
         packet.chunkZ = buf.readInt();
 
-        packet.drainSpots = new ArrayList<>();
+        packet.drainSpots = new HashMap<>();
         var amount = buf.readInt();
-        for (var i = 0; i < amount; i++)
+        for (var i = 0; i < amount; i++) {
-            packet.drainSpots.add(new AuraChunk.DrainSpot(buf.readNbt()));
+            packet.drainSpots.put(
+                    BlockPos.of(buf.readLong()),
+                    new MutableInt(buf.readInt())
+            );
+        }
 
         return packet;
     }
@@ -46,8 +51,10 @@ public class PacketAuraChunk {
         buf.writeInt(packet.chunkZ);
 
         buf.writeInt(packet.drainSpots.size());
-        for (var entry : packet.drainSpots)
+        for (var entry : packet.drainSpots.entrySet()) {
-            buf.writeNbt(entry.serializeNBT());
+            buf.writeLong(entry.getKey().asLong());
+            buf.writeInt(entry.getValue().intValue());
+        }
     }
 
     public static void onMessage(PacketAuraChunk message, Supplier<NetworkEvent.Context> ctx) {