Ellpeck/MLEM
1
0
Fork 0
mirror of https://github.com/Ellpeck/MLEM.git synced 2024-11-25 22:18:34 +01:00
Code Issues Projects Releases Wiki Activity

further improved performance of panels when removing a large amount of children

Browse source
This commit is contained in:
Ell 2024-04-02 13:36:24 +02:00
parent 7f4cc773ec
commit 3bb3ae20c0
1 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
MLEM.Ui/Elements/Panel.cs
View file

@ -64,6 +64,7 @@ namespace MLEM.Ui.Elements {
private float scrollBarChildOffset; private float scrollBarChildOffset;
private StyleProp<float> scrollBarOffset; private StyleProp<float> scrollBarOffset;
private float lastScrollOffset; private float lastScrollOffset;
private bool childrenDirtyForScroll;
/// <summary> /// <summary>
/// Creates a new panel with the given settings. /// Creates a new panel with the given settings.
@ -157,8 +158,16 @@ namespace MLEM.Ui.Elements {
// when removing children, our scroll bar might have to be hidden // when removing children, our scroll bar might have to be hidden
// if we don't do this before adding children again, they might incorrectly assume that the scroll bar will still be visible and adjust their size accordingly // if we don't do this before adding children again, they might incorrectly assume that the scroll bar will still be visible and adjust their size accordingly
if (this.System != null) this.childrenDirtyForScroll = true;
}
/// <inheritdoc />
public override T AddChild<T>(T element, int index = -1) {
// if children were recently removed, make sure to update the scroll bar before adding new ones so that they can't incorrectly assume the scroll bar will be visible
if (this.childrenDirtyForScroll && this.System != null)
this.ScrollSetup(); this.ScrollSetup();
return base.AddChild(element, index);
} }
/// <inheritdoc /> /// <inheritdoc />
@ -277,6 +286,8 @@ namespace MLEM.Ui.Elements {
/// Prepares the panel for auto-scrolling, creating the render target and setting up the scroll bar's maximum value. /// Prepares the panel for auto-scrolling, creating the render target and setting up the scroll bar's maximum value.
/// </summary> /// </summary>
protected virtual void ScrollSetup() { protected virtual void ScrollSetup() {
this.childrenDirtyForScroll = false;
if (!this.scrollOverflow || this.IsHidden) if (!this.scrollOverflow || this.IsHidden)
return; return;