Ellpeck/MLEM
1
0
Fork 0
mirror of https://github.com/Ellpeck/MLEM.git synced 2024-11-26 06:28:35 +01:00
Code Issues Projects Releases Wiki Activity

Marked StyleProp equality members as obsolete

Browse source
This commit is contained in:
Ell 2022-01-22 23:20:04 +01:00
parent faa400c4e6
commit 94b6aa0d1b
2 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
CHANGELOG.md
View file

@ -35,6 +35,9 @@ Improvements
Fixes Fixes
- Fixed paragraph links having incorrect hover locations when using special text alignments - Fixed paragraph links having incorrect hover locations when using special text alignments
Removals
- Marked StyleProp equality members as obsolete
### MLEM.Extended ### MLEM.Extended
Improvements Improvements
- Preserve texture region names when converting between MLEM and MG.Extended - Preserve texture region names when converting between MLEM and MG.Extended

5
MLEM.Ui/Style/StyleProp.cs
View file

@ -75,6 +75,7 @@ namespace MLEM.Ui.Style {
/// <summary>Indicates whether the current object is equal to another object of the same type.</summary> /// <summary>Indicates whether the current object is equal to another object of the same type.</summary>
/// <param name="other">An object to compare with this object.</param> /// <param name="other">An object to compare with this object.</param>
/// <returns>true if the current object is equal to the <paramref name="other">other</paramref> parameter; otherwise, false.</returns> /// <returns>true if the current object is equal to the <paramref name="other">other</paramref> parameter; otherwise, false.</returns>
[Obsolete("StyleProp equality is ambiguous as it is not clear whether priority is taken into account. Compare Values instead.")]
public bool Equals(StyleProp<T> other) { public bool Equals(StyleProp<T> other) {
return EqualityComparer<T>.Default.Equals(this.Value, other.Value); return EqualityComparer<T>.Default.Equals(this.Value, other.Value);
} }
@ -82,12 +83,14 @@ namespace MLEM.Ui.Style {
/// <summary>Indicates whether this instance and a specified object are equal.</summary> /// <summary>Indicates whether this instance and a specified object are equal.</summary>
/// <param name="obj">The object to compare with the current instance.</param> /// <param name="obj">The object to compare with the current instance.</param>
/// <returns>true if <paramref name="obj">obj</paramref> and this instance are the same type and represent the same value; otherwise, false.</returns> /// <returns>true if <paramref name="obj">obj</paramref> and this instance are the same type and represent the same value; otherwise, false.</returns>
[Obsolete("StyleProp equality is ambiguous as it is not clear whether priority is taken into account. Compare Values instead.")]
public override bool Equals(object obj) { public override bool Equals(object obj) {
return obj is StyleProp<T> other && this.Equals(other); return obj is StyleProp<T> other && this.Equals(other);
} }
/// <summary>Returns the hash code for this instance.</summary> /// <summary>Returns the hash code for this instance.</summary>
/// <returns>A 32-bit signed integer that is the hash code for this instance.</returns> /// <returns>A 32-bit signed integer that is the hash code for this instance.</returns>
[Obsolete("StyleProp equality is ambiguous as it is not clear whether priority is taken into account. Compare Values instead.")]
public override int GetHashCode() { public override int GetHashCode() {
return EqualityComparer<T>.Default.GetHashCode(this.Value); return EqualityComparer<T>.Default.GetHashCode(this.Value);
} }
@ -122,6 +125,7 @@ namespace MLEM.Ui.Style {
/// <param name="left">The left style property.</param> /// <param name="left">The left style property.</param>
/// <param name="right">The right style property.</param> /// <param name="right">The right style property.</param>
/// <returns>Whether the two style properties are equal.</returns> /// <returns>Whether the two style properties are equal.</returns>
[Obsolete("StyleProp equality is ambiguous as it is not clear whether priority is taken into account. Compare Values instead.")]
public static bool operator ==(StyleProp<T> left, StyleProp<T> right) { public static bool operator ==(StyleProp<T> left, StyleProp<T> right) {
return left.Equals(right); return left.Equals(right);
} }
@ -132,6 +136,7 @@ namespace MLEM.Ui.Style {
/// <param name="left">The left style property.</param> /// <param name="left">The left style property.</param>
/// <param name="right">The right style property.</param> /// <param name="right">The right style property.</param>
/// <returns>Whether the two style properties are not equal.</returns> /// <returns>Whether the two style properties are not equal.</returns>
[Obsolete("StyleProp equality is ambiguous as it is not clear whether priority is taken into account. Compare Values instead.")]
public static bool operator !=(StyleProp<T> left, StyleProp<T> right) { public static bool operator !=(StyleProp<T> left, StyleProp<T> right) {
return !left.Equals(right); return !left.Equals(right);
} }